Skip to content

[Hub Generated] Publish private branch 'avjan/new-api-version-for-vasetteings'#24251

Merged
chunyu3 merged 15 commits into
mainfrom
published/Nomigori96MS/azure-rest-api-specs-pr/avjan/new-api-version-for-vasetteings
Jun 8, 2023
Merged

[Hub Generated] Publish private branch 'avjan/new-api-version-for-vasetteings'#24251
chunyu3 merged 15 commits into
mainfrom
published/Nomigori96MS/azure-rest-api-specs-pr/avjan/new-api-version-for-vasetteings

Conversation

@AvishalomJ
Copy link
Copy Markdown
Contributor

@AvishalomJ AvishalomJ commented Jun 1, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@AvishalomJ
Copy link
Copy Markdown
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12575

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @AvishalomJ Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Jun 1, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.2) new version base version
    package-composite-v3 package-composite-v3(4394894) package-composite-v3(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 254 Errors, 0 Warnings failed [Detail]

    Tag package-composite-v3; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 214, untested: 0, failed: 175, passed: 39

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.Security/iotSecuritySolutions/write' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-mMgoZH-24251/providers/Microsoft.Security/iotSecuritySolutions/solutionhx199l'; however, it does not have permission to perform action 'write' on the linked scope(s) '/subscriptions/075423e9-7d33-4166-8bdf-3920b04e3735/resourceGroups/myRg/providers/Microsoft.Devices/IotHubs/FirstIotHub' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: IotSecuritySolution_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Security/iotSecuritySolutions/solutionhx199l' under resource group 'apiTest-mMgoZH-24251' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: IotSecuritySolution_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Security/iotSecuritySolutions/solutionhx199l' under resource group 'apiTest-mMgoZH-24251' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: IotSecuritySolution_Update
    CLIENT_ERROR statusCode: 409,
    errorCode: MissingRegistrationForLocation,
    errorMessage: The subscription is not registered for the resource type 'securityConnectors' in the location 'eastus2euap'. Please re-register for this provider in order to have access to this location.
    Source: runtime
    OperationId: SecurityConnectors_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Security/securityConnectors/securitybvbv1f' under resource group 'apiTest-mMgoZH-24251' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: SecurityConnectors_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Security/securityConnectors/securitybvbv1f' under resource group 'apiTest-mMgoZH-24251' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: SecurityConnectors_Update
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/pricings/write' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/providers/Microsoft.Security/pricings/pricingn0steit' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: Pricings_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidResourceName,
    errorMessage: The name 'pricingn0steit' is not a valid name. Possible pricing bundle names: VirtualMachines, SqlServers, AppServices, StorageAccounts, SqlServerVirtualMachines, KubernetesService, ContainerRegistry, KeyVaults, Dns, Arm, OpenSourceRelationalDatabases, CosmosDbs, Containers, CloudPosture, Api.
    Source: runtime
    OperationId: Pricings_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: MissingSubscription,
    errorMessage: The request did not have a subscription or a valid tenant level resource provider.
    Source: runtime
    OperationId: GovernanceRules_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: MissingSubscription,
    errorMessage: The request did not have a subscription or a valid tenant level resource provider.
    Source: runtime
    OperationId: GovernanceRules_List
    CLIENT_ERROR statusCode: 404,
    errorCode: MissingSubscription,
    errorMessage: The request did not have a subscription or a valid tenant level resource provider.
    Source: runtime
    OperationId: GovernanceRules_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: MissingSubscription,
    errorMessage: The request did not have a subscription or a valid tenant level resource provider.
    Source: runtime
    OperationId: GovernanceRules_OperationResults
    CLIENT_ERROR statusCode: 404,
    errorCode: MissingSubscription,
    errorMessage: The request did not have a subscription or a valid tenant level resource provider.
    Source: runtime
    OperationId: GovernanceRules_Execute
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/ingestionSettings/write' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/providers/Microsoft.Security/ingestionSettings/ingestioqrmiyj' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: IngestionSettings_Create
    SERVER_ERROR statusCode: 502,
    errorCode: InvalidGatewayHost,
    errorMessage: Host name resolution failed for 'Microsoft.Security'; cannot fulfill the request.
    Source: runtime
    OperationId: IngestionSettings_List
    SERVER_ERROR statusCode: 502,
    errorCode: InvalidGatewayHost,
    errorMessage: Host name resolution failed for 'Microsoft.Security'; cannot fulfill the request.
    Source: runtime
    OperationId: IngestionSettings_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/ingestionSettings/listTokens/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: IngestionSettings_ListTokens
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/ingestionSettings/listConnectionStrings/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: IngestionSettings_ListConnectionStrings
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.Logic/workflows/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-mMgoZH-24251/providers/Microsoft.Security/automations/automativ6am39', however the linked subscription 'e54a4a18-5b94-4f90-9471-bd3decad8a2e' was not found.
    Source: runtime
    OperationId: Automations_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Security/automations/automativ6am39' under resource group 'apiTest-mMgoZH-24251' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Automations_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.Logic/workflows/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-mMgoZH-24251/providers/Microsoft.Security/automations/automativ6am39', however the linked subscription 'e54a4a18-5b94-4f90-9471-bd3decad8a2e' was not found.
    Source: runtime
    OperationId: Automations_Validate
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/workspaceSettings/write' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/providers/Microsoft.Security/workspaceSettings/workspacjge7dx' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: WorkspaceSettings_Create
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "id" cannot be sent in the request
    Source: request
    OperationId: WorkspaceSettings_Create
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
    Source: request
    OperationId: WorkspaceSettings_Create
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "type" cannot be sent in the request
    Source: request
    OperationId: WorkspaceSettings_Create
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidInput,
    errorMessage: Invalid workspace settings name 'workspacjge7dx' , only default is allowed
    Source: runtime
    OperationId: WorkspaceSettings_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Security/workspaceSettings/write' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/providers/Microsoft.Security/workspaceSettings/workspacjge7dx' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: WorkspaceSettings_Update
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: scope
    Source: request
    OperationId: WorkspaceSettings_Update
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "id" cannot be sent in the request
    Source: request
    OperationId: WorkspaceSettings_Update
    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "name" cannot be sent in the request
    Source: request
    OperationId: WorkspaceSettings_Update
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Jun 1, 2023

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Jun 1, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Security https://apiview.dev/Assemblies/Review/c71a45dc2d3f4c0c88209885d3f7109d

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 1, 2023
    @mentat9
    Copy link
    Copy Markdown
    Member

    mentat9 commented Jun 1, 2023

    @AvishalomJ - Please carefully and completely fill out the submission form. Your PR cannot be routed correctly and reviewed without that information.

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 1, 2023
    @AvishalomJ
    Copy link
    Copy Markdown
    Contributor Author

    @AvishalomJ - Please carefully and completely fill out the submission form. Your PR cannot be routed correctly and reviewed without that information.

    Done.
    In general - this is a new resource type in Microsoft.Security, thanks.

    @openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2023
    @ms-zhenhua ms-zhenhua removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 5, 2023
    @openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2023
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi @AvishalomJ, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @ms-zhenhua ms-zhenhua added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 6, 2023
    @openapi-workflow-bot openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2023
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi, @AvishalomJ your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 7, 2023
    @Wzb123456789 Wzb123456789 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 8, 2023
    @chunyu3 chunyu3 merged commit 483cdd3 into main Jun 8, 2023
    @chunyu3 chunyu3 deleted the published/Nomigori96MS/azure-rest-api-specs-pr/avjan/new-api-version-for-vasetteings branch June 8, 2023 05:07
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    …etteings' (Azure#24251)
    
    * Added stable api version for ServerVulnerabilityAssessmentsSettings
    
    * Update system data ref and readme's api-version
    
    * Update ServerVulnerabilityAssessmentsSetting's definition ref
    
    * Updated ServerVulnerabilityAssessmentsSetting's systemData property
    
    * Updated ServerVulnerabilityAssessmentsSetting ref to proxyResource
    
    * Revert "Updated ServerVulnerabilityAssessmentsSetting ref to proxyResource"
    
    This reverts commit f5b7b44.
    
    * Update specification/security/resource-manager/Microsoft.Security/stable/2023-05-01/ServerVulnerabilityAssessmentsSettings.json
    
    Co-authored-by: Zhenhua Hu <zhhu@microsoft.com>
    
    * Update ServerVulnerabilityAssessmentsSettings.json - minor changes
    
    * Update ServerVulnerabilityAssessmentsSettings.json - Added 200 ok response for put request
    
    * Updated ServerVulnerabilityAssessmentsSetting's references to the latest - v5
    
    * Update PutServerVulnerabilityAssessmentsSetting_example.json added 200 ok response
    
    ---------
    
    Co-authored-by: Zhenhua Hu <zhhu@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants